windows_motd_title parameter added #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows "Message of the day" title now customizable for corporate consumption.
This will test the windows_motd_title param
hunner
suggested changes
Mar 14, 2018
| @@ -21,6 +21,7 @@ | |||
| $issue_content = undef, | |||
| $issue_net_template = undef, | |||
| $issue_net_content = undef, | |||
| $windows_motd_title = 'Message of the day', | |||
There was a problem hiding this comment.
Could you also add an @param docline above for documentation?
spec/classes/motd_spec.rb
Outdated
| @@ -213,6 +213,7 @@ | |||
| let(:params) do | |||
| { | |||
| content: 'Hello!', | |||
| windows_motd_title: 'This is the title.', | |||
There was a problem hiding this comment.
Looks like the indentation is off here. Hard tabs should not be used, only spaces.
spec/classes/motd_spec.rb
Outdated
| is_expected.to contain_Registry_value('HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\policies\system\legalnoticecaption').with( | ||
| ensure: 'present', | ||
| type: 'string', | ||
| data: 'This is the title.', |
Align the spec.
cgpeanut
commented
Mar 19, 2018
Added the @param comment line to init.pp per request
|
@hunner Are you satisfied with the changes made?? |
|
yep
…On Wed, Apr 11, 2018 at 6:32 AM, david22swan ***@***.***> wrote:
@hunner <https://github.com/hunner> Are you satisfied with the changes
made??
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQAYrQz2nptOPmffaCuvpU7Cc3GV0SiVks5tnem3gaJpZM4Spfsy>
.
|
hunner
approved these changes
May 3, 2018
|
@cgpeanut great PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows users to customize the windows message of the day title.