Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-7069) Add compatibility for AIX #115

Merged
merged 3 commits into from
May 3, 2018
Merged

(MODULES-7069) Add compatibility for AIX #115

merged 3 commits into from
May 3, 2018

Conversation

jarretlavallee
Copy link
Contributor

This PR adds support for AIX to specify a /etc/motd, /etc/issue and /etc/issue.net.

@jarretlavallee
Copy link
Contributor Author

Fixed the release_checks deprecation issue with the spec tests. Do you want me to update this to PDK 1.5.0?

@pmcmaw
Copy link
Contributor

pmcmaw commented May 3, 2018

Hey @jarretlavallee

I just want to thank you for taking your time to submit this PR. We will be running a pdk update soon for pdk 1.5.0 so your temporary fix for release_checks is perfect.

If you could remove the AIX entries from the metadata.json I will get your PR merged.

When merging this PR I would like to make you aware this will make the code base compatible with the module, however Puppet will not support this operating system. By support I mean we will not be running tests against this OS or providing bug fixes specific to this OS. I would like to make sure you are ok with this before I merge. 👍

Jarret Lavallee added 3 commits May 3, 2018 09:11
(MODULES-7069) Add support for AIX
37d313c 
Prior to this commit this module had a noop for AIX. This commit adds
support for AIX to specify an `/etc/motd`, `/etc/issue` and
`/etc/issue.net`.
(FM-6043) Manage file owner and group
7d19024 
Prior to this commit, the files did nto specify the owner or group for
the files that it manages. This commit manages the file owner and group
for all files in the module.
(MAINT) Fix Travis release_check tests
dc907dd 
Prior to this commit, the travis release_check tests were failing due to
a deprecation warning. This commit updates the .sync.yml to specify the
puppet 4.x version when using ruby 2.1.9.
@jarretlavallee
Copy link
Contributor Author

@pmcmaw Thanks for taking the time to review this! I removed the updates to the metadata.json as I am perfectly fine without the AIX system tests. Thanks!

@pmcmaw pmcmaw changed the title (MODULES-7069) Add support for AIX (MODULES-7069) Add compatibility for AIX May 3, 2018
@pmcmaw pmcmaw merged commit 0c11429 into puppetlabs:master May 3, 2018
@pmcmaw
Copy link
Contributor

pmcmaw commented May 3, 2018

@jarretlavallee thank you for this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarretlavallee @pmcmaw @LukasAud