(maint) removing registry pin, update stdlib bound #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphoney
force-pushed
the
remove_stdlib_pin
branch
from
5ad7cd1
to
07a554e
Compare
|
I can confirm these changes have passed on the internal adhoc pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping puppetlabs-stdlib upper boundary as puppetlabs-stdlib 5.0.0 has been released.
Removing the pin to registry as it is now on version 2.2.0 and the pinned version was very old.
Finally removing the install code in
puppetlabs_spec_helper_acceptance.rbas there is no need to install the registry modules again when it is listed in.fixtures.ymlandmetadata.json.