Beaker tests modules 2665 #23
Conversation
iankronquist
force-pushed
the
beaker-tests-MODULES-2665
branch
from
c4f1f01
to
de80f69
Compare
| end | ||
|
|
||
|
|
||
| if fact('osfamily') == 'Debian' || fact('osfamily') == 'RedHat' |
There was a problem hiding this comment.
Just a discussion topic, but would it be better if this said:
if fact('osfamily') != 'Windows'
Reasoning is, if we have an motd module, we should eventually (definitely) expand the support to include other *nix platforms that have /etc/motd management, like SuSE, AmazonLinux, etc. And it would be easier for the test to exclude windows vs include all the linux distros.
|
@bmjen Fixed. Thanks. |
iankronquist
force-pushed
the
beaker-tests-MODULES-2665
branch
2 times, most recently
from
5b91985
to
10339c0
Compare
|
@iankronquist The line in the test with my comment still isn't updated. |
iankronquist
force-pushed
the
beaker-tests-MODULES-2665
branch
from
10339c0
to
144c3fe
Compare
| @@ -0,0 +1,24 @@ | |||
| require 'beaker-rspec' | |||
There was a problem hiding this comment.
This file should not be here. Looks like it was renamed but the old one was not removed.
There was a problem hiding this comment.
Whoops. I think this accounts for some of the confusion earlier -- I was editing this file and not spec/spec_helper_acceptance.rb.
Also remove old dependencies which were deprecated.
According to a conversation on IRC with Hunner:
-----------------------------------------------
14:44:22 Hunner | Windows support sounds nice, but maybe we should just ditch it considering the
| overhead it adds
14:44:25 Hunner | let me check
14:49:05 Hunner | radens: Don't worry about running the windows tests. Document it and all, but I
| don't want to stick you with hours of getting windows VMs working... we'll get our
| qa to do that :D
14:50:45 radens | Okay, I'll ditch it.
-----------------------------------------------
iankronquist
force-pushed
the
beaker-tests-MODULES-2665
branch
from
144c3fe
to
ad403d1
Compare
Once I get a +1 I'll squash the commits according to the contributing guidelines.