Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added class parameter for external templates and tests #7

Merged

Conversation

solarkennedy
Copy link
Contributor

In the readme it says you can do this:

class { 'motd':
  template => template('mymodule/mytemplate.erb'),
}

But unless I'm missing something, I don't see a class parameter that allows that?

This pull request adds that feature, so I can use this module with my own templates without modifying the module in any way!

@daniellawrence
Copy link

👍

@kian
Copy link

kian commented Dec 13, 2013

👍 I would use this feature as well. Would love to delete my personal fork.

@mlocher
Copy link

mlocher commented Dec 27, 2013

👍

@solarkennedy
Copy link
Contributor Author

This silly module may be very far down on @puppetlabs todo list :)

@mlocher
Copy link

mlocher commented Dec 27, 2013

Probably, in the end I used your branch, but it's still the most downloaded one on the puppet forge.

@apenney
Copy link

apenney commented Apr 10, 2014

No module is too small for us!

apenney pushed a commit that referenced this pull request Apr 10, 2014
…plate

Added class parameter for external templates and tests
@apenney apenney merged commit ed8fb8b into puppetlabs:master Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants