(MODULES-3593) Changes default MOTD to something more useful #76
Conversation
Improves out-of-the-box useability. Changes default message to include FQDN, Processor, and Kernel in addition to the old messages Operating system and free memory. Removes domain as this is included in FQDN. Removes test to test when domain fact is nil.
|
As the |
|
@glennsarti this is an interesting comment. We reviewed the tests, and it appears that this wouldn't add valuable coverage. Our template test was modified to take different facts and produce different output. A windows test would be redundant because we would just be changing facts in the stub to have windows facts rather than linux facts. Windows has it's own conditional in init.pp, however, the template has been rendered and stored in $motd_content at the top of the file. As for the code in the windows conditional, it appears it is being covered in the windows test by passing in a arbitrary string. I'm happy to review the tests together if you still have concerns. Thanks for your comment! |
templates/motd.erb
Outdated
| <%= @operatingsystem %> <%= @operatingsystemrelease %> <%= @architecture %> | ||
|
|
||
| FQDN: <%= @fqdn %> (<%= @ipaddress %>) | ||
| Processor: <%= @processor1 %> |
There was a problem hiding this comment.
This should probably be processor0 not processor1. On a single physical CPU with multiple cores, only processor0 exists.
|
Yay for tests!!! Thanks! |
The procssor fact stores processors in an array, so the first one is at '0' not '1'. Changed templates and tests accordingly.
Improves out-of-the-box useability. Changes default message to include FQDN, Processor, and Kernel in addition to the old messages Operating system and free memory. Removes domain as this is included in FQDN. Removes test to test when domain fact is nil.