(maint) Convert module for PDK Compatibility #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmjen
force-pushed
the
pdk-convert
branch
4 times, most recently
from
03f5115
to
e02b7a8
Compare
|
Looks good, but is there a way of ignoring modulesync files? These would be overwritten anyway on the next modulesync.
|
|
Unfortunately, we don't have the capability of ignoring files at the moment. That's definitely something we'll have to add to the convert feature. |
|
@willmeek also, with this module being converted now, we may think about removing it from the modulesync managed modules, and making PRs to pdk-templates when changes are needed/wanted. |
|
PR to Remove motd from modulesync - puppetlabs/modulesync_configs#172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.