Remove requirement for rspec-collection_matchers
RSpec 3.0 moved collection matchers into their own gem, which our puppet-module-* gems do not include as a dependency. Update tests to not depend on the collection matchers.
Updated rubocop violations using `pdk validate -a`
Remove Performance/RedundantMatch violation
Note %(...) is a string literal, which String#match converts to a regexp. So short-circuit that by specifying a regexp.
Most of this change is whitespace indentation.
Remove RSpec/InstanceVariable violations
Since let blocks are evaluated lazily, we preserve the old behavior where the code in the `before :each` block is evaluated prior to the let block.
Disable some style/layout rubocop checks
Disable IndentHeredoc as that relies on an external gem. Double negation is sometimes useful. GuardClause is sometimes necessary when multiple statements are affected by a condition. MultilineBlockChain is fine.
Disable rspec rubocop checks in integration test
The integration test uses instance variables to keep state across different rspec examples, such as tracking the transition from unmounted to mounted. As the state changes, so do the expectations for the next test. Unwinding that would take some time, time better spent converting the test to an acceptance test. So for now disable those checks for that test only.
Move before/after/let methods into a shared context
DRY beaker tests by including a shared context, passing in the agent host to the shared context for that example group.
Remove puppet 4.x from travis test matrix
Due to PUP-6648, module unit tests that rely on `catalog.apply` will fail when tested against puppet versions < 5.3.4, as that was the first version to only enable persistence when running `puppet agent`, see PUP-8227.
The mount module is not supported on windows, remove appveyor.yml
Update README and REFERENCE documentation
Add a pointer to mount_providers module. See also puppet-users discussion: https://groups.google.com/d/msg/puppet-users/LTC45I1J-KY/_A-RM473UnQJ
Merge pull request #1 from puppetlabs/extraction
Initial mount module extraction
Merge pull request #2 from puppetlabs/release_100
Prep for 1.0.0 release