(MODULES-3623) Centralise MySQL calls... #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so they can all be modified from one place. The current codebase handles each mysql call via calls to the command-line mysql client. There are basically only two sets of options passed, but the options are repeated separately in various places throughout the code. The new self.mysql function now issues the call to the mysql client with one of the two sets of options (selected via an optional function parameter). Now the options to all mysql calls can be modified from one place. This will be useful when we are converting the module to allow for databases on multiple remote servers, since we will be able to add the -h switch to all calls at once.
mysql_grant now checks for mysql command
hunner
added a commit
to hunner/puppetlabs-mysql
that referenced
this pull request
Jan 23, 2018
shawnferry
pushed a commit
to shawnferry/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so they can all be modified from one place.
Rebase and squash of #904