Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for RHSCL mysql versions and support for .mylogin.cnf for MySQL 5.6.6+ #1061

Merged
merged 1 commit into from Nov 9, 2018

Conversation

DJMuggs
Copy link

@DJMuggs DJMuggs commented Mar 28, 2018

Added support for RHSCL versions.

We need additional LD_LIBRARY_PATH paths for RHSCL.
Fixed db import when using RHSCL, allow to extend the default path to find the mysql executable.

Allow support for .mylogin.cnf when using MySQL 5.6+.
We cannot generate this file from puppet so we need to provide one ourselves.

@@ -21,6 +21,8 @@
$service_provider = $mysql::params::server_service_provider,
$create_root_user = $mysql::params::create_root_user,
$create_root_my_cnf = $mysql::params::create_root_my_cnf,
$create_root_login_file = $mysql::params::create_root_login_file,
$login_file = $mysql::params::login_file,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the expected workflow of passing a login file? Why is it using the source parameter instead of content? Where does it come from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to create the login file first with mysql_config_editor, this creates an encrypted file.
And because the tool uses interactive prompt for the password, it's not possible to create during a puppet run.
So that's why you need to source this instead of using content.

https://dev.mysql.com/doc/refman/5.6/en/mysql-config-editor.html

@david22swan
Copy link
Member

@DJMuggs Is there any movement on this pr?

Allow use of .mylogin.cnf for mysql 5.6 and up.
@DJMuggs
Copy link
Author

DJMuggs commented Oct 19, 2018

rebased it

@david22swan
Copy link
Member

@DJMuggs If possible could you add an acceptance test to the module to cover the use of .mylogin.cnf.

@DJMuggs
Copy link
Author

DJMuggs commented Nov 1, 2018

@DJMuggs If possible could you add an acceptance test to the module to cover the use of .mylogin.cnf.

Creating this file goes through an interactive password prompt, so this not possible at the moment.
https://dev.mysql.com/doc/refman/5.6/en/mysql-config-editor.html

@david22swan david22swan merged commit ecce0b3 into puppetlabs:master Nov 9, 2018
@david22swan
Copy link
Member

@DJMuggs Merged. Thanks for the work you put in.
screen shot 2018-11-09 at 2 23 40 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants