Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) - Change versioning comparison #1123

merged 1 commit into from Sep 17, 2018


Copy link

@eimlav eimlav commented Sep 17, 2018

Changed comparison of versions from default string comparisons to Gem::Version as the string comparisons use lexicographical ordering which can fail on certain cases e.g. '4.10.5' > '4.10.12' resolves to true which is incorrect as 4.10.12 is a later version than 4.10.5 .

@eimlav eimlav added the bugfix label Sep 17, 2018
@tphoney tphoney merged commit 680149f into puppetlabs:master Sep 17, 2018
@eimlav eimlav deleted the version-fix branch September 17, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants