Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-7857) Support user creation on galera #1130

Merged

Conversation

MaxFedotov
Copy link

Support user creation on galera. Add IF NOT EXISTS to CREATE USER in mysql_user provider
Description of issue in jira - https://tickets.puppetlabs.com/browse/MODULES-7857

@david22swan
Copy link
Member

@MaxFedotov Could you add some test coverage for your new feature and update the docs please?

@MaxFedotov
Copy link
Author

MaxFedotov commented Oct 11, 2018

@david22swan Hi. Can you please clarify, which docs should be updated? This PR doesn't add new functionality, it's just reuses the same logic, which is already implemented for DROP USER

self.class.mysql_caller("DROP USER #{if_exists}'#{merged_name}'", 'system')
. I've looked throught all docs, and wasn't able to find anything related to this.

@MaxFedotov
Copy link
Author

MaxFedotov commented Oct 11, 2018

@david22swan I've rebased on current master and slightly modified my PR. Also i've updated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants