Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assign to hash after creation #114

Merged
merged 1 commit into from
Sep 5, 2012

Conversation

dalen
Copy link

@dalen dalen commented Sep 5, 2012

We shouldn't modify a variable after creating it. It is just a bug that
it is possible at all.

@bodepd
Copy link
Contributor

bodepd commented Sep 5, 2012

@dalen I am not how I feel about the immutability of hashes in Puppet, but I also wish that you could change the values of all variables, so maybe I am not the best person to comment on this :)

That point aside, all of this code is actually here b/c of issues with anonymous hashes in Puppet 2.6.x. Your pull request breaks this module (and causes parse errors) for Puppet 2.6.x.

@dalen
Copy link
Author

dalen commented Sep 5, 2012

okay, but we can keep the variable then but not modify it after creation, I'll revise the patch.

We shouldn't modify a variable after creating it. It is just a bug that
it is possible at all.
@dalen
Copy link
Author

dalen commented Sep 5, 2012

That should hopefully work on 2.6.x, I don't have any install of that to verify.

@bodepd
Copy link
Contributor

bodepd commented Sep 5, 2012

I verified the syntax back to 2.6.5

bodepd added a commit that referenced this pull request Sep 5, 2012
Don't assign to hash after creation
@bodepd bodepd merged commit 8816442 into puppetlabs:master Sep 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants