Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate option for xtrabackup script #1176

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Rotate option for xtrabackup script #1176

merged 1 commit into from
Apr 1, 2019

Conversation

elfranne
Copy link
Contributor

Update to xtrabackup:

  • set -o pipefail: failed piped command will give a success (pipe worked fine).
  • copied the cleanup bits from from the mysqlbackup.sh.erb and the mkdir -p $DIR

@david22swan
Copy link
Member

@elfranne This looks like a good feature to me, however in order for it to be merged we would first need default values for the new variables added to the manifest, along with documentation explaining their purpose and how they should be used.
Once this is done this should be able to be merged.

@elfranne
Copy link
Contributor Author

elfranne commented Apr 1, 2019

Those option are already in the manifest and are documented:
https://github.com/puppetlabs/puppetlabs-mysql/blob/master/manifests/server/backup.pp
and the provider:
https://github.com/puppetlabs/puppetlabs-mysql/blob/master/manifests/backup/xtrabackup.pp

But they were never actually implemented in the xtrabackup provider, only in mysqldump provider.

@david22swan
Copy link
Member

Screen Shot 2019-04-01 at 12 37 47 PM

Ok, your changes look good overall and they have passed through the adhoc pipeline cleanly so I'm gonna give this a merge. Thanks for putting in the work. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants