Fix mysql::sql task error message #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
referenced
this pull request
Oct 14, 2019
For whatever reason, rubocop cannot see that stderr is indeed a used variable.
|
We also need to update the response to add a |
alexjfisher
force-pushed
the
fix_task_error_message
branch
from
ed30a49
to
6229afc
Compare
Because of misplaced `"` no interpolation of the error message was actually taking place. Rubocop had been warning about this bug, but was deactivated in both tasks (in different ways and by two different people)
alexjfisher
force-pushed
the
fix_task_error_message
branch
from
6229afc
to
973c46e
Compare
|
@adreyer Would you like to? I'm not too confident with bolt at the moment. Similar fix needed in puppetlabs/postgresql (and probably other modules) too. |
|
@nicklewis I've found a similar bug in the other task |
michaeltlombardi
approved these changes
Oct 16, 2019
|
Thanks for the fix @alexjfisher! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of misplaced
"no interpolation of the error message wasactually taking place. After fixing this, the
Lint/UselessAssignmentrubocop violation that had been disabled goes away too.