Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed_dirs parameter #1305

Merged
merged 5 commits into from Jun 23, 2020

Conversation

evgenkisel
Copy link
Contributor

These changes resolve a problem described in the issue MODULES-10679.
Updated the class mysql::server to use the new parameter managed_dirs which allows to set a list of directories which can be managed by the class mysql::server::managed_dirs

Eugeny Kisel added 2 commits May 22, 2020 14:33
…config only for Debian, because

there's dependency of Debian tool
unless  => "/usr/bin/dpkg -s ${mysql::server::package_name}",
Created the parameter managed_dirs for the class mysql::server to allow use the class mysql::server::managed_dirs
@evgenkisel evgenkisel requested a review from a team as a code owner June 1, 2020 08:43
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4a056a8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1305   +/-   ##
=========================================
  Coverage          ?   50.23%           
=========================================
  Files             ?       22           
  Lines             ?     1045           
  Branches          ?        0           
=========================================
  Hits              ?      525           
  Misses            ?      520           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a056a8...a221327. Read the comment docs.

@sheenaajay
Copy link
Contributor

Thank you @evgenkisel for submitting the PR.

manifests/server.pp Outdated Show resolved Hide resolved
…mysql::params::managed_dirs.

Updated REFERENCE.md
@sheenaajay sheenaajay force-pushed the fix_managed_dirs branch 2 times, most recently from 3a94a5f to 1ea69bf Compare June 18, 2020 12:59
@sanfrancrisko sanfrancrisko changed the title Fix managed dirs Add managed_dirs parameter Jun 23, 2020
@sanfrancrisko sanfrancrisko merged commit 6af116c into puppetlabs:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants