-
Notifications
You must be signed in to change notification settings - Fork 794
Handle cron package from different module #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
based on this puppetlabs#1269
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
=======================================
Coverage 50.23% 50.23%
=======================================
Files 22 22
Lines 1045 1045
=======================================
Hits 525 525
Misses 520 520 Continue to review full report at Codecov.
|
Hi @ashish1099, this LGTM! Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙋♀️
} elsif $::osfamily == 'RedHat' { | ||
ensure_packages('cronie') | ||
} elsif $::osfamily != 'FreeBSD' { | ||
ensure_packages('cron') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this even do on FreeBSD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @igalic, we don't usually test on FreeBSD, so this can be a mistake. I'll have a look! Thank you for highlighting this, feel free to open a PR if you want! Thanks again! Cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i haven't actually used MySQL since switching to FreeBSD, it's all been SQLite 😅
Backup should only install cron, if one wants it.
based on this #1269