Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove control character from manifests/server.pp #1312

Merged
merged 1 commit into from Jul 1, 2020

Conversation

tomkrouper
Copy link
Contributor

A check for ascii characters revealed that the contraction for "do not"
was not a valid ascii character, this changes that.

resolves: https://tickets.puppetlabs.com/browse/MODULES-10723

A check for ascii characters revealed that the contraction for "do not"
was not a valid ascii character, this changes that.
@tomkrouper tomkrouper requested a review from a team as a code owner June 30, 2020 21:37
@puppet-community-rangefinder
Copy link

mysql::server is a class

Breaking changes to this file WILL impact these 74 modules (exact match):
Breaking changes to this file MAY impact these 50 modules (near match):

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

Codecov Report

Merging #1312 into master will increase coverage by 5.45%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
+ Coverage   50.23%   55.69%   +5.45%     
==========================================
  Files          22       22              
  Lines        1045     1045              
==========================================
+ Hits          525      582      +57     
+ Misses        520      463      -57     
Impacted Files Coverage Δ
lib/puppet/provider/mysql_user/mysql.rb 87.58% <40.00%> (ø)
...ppet/provider/mysql_login_path/mysql_login_path.rb 90.32% <0.00%> (+61.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207ba9c...c8b0817. Read the comment docs.

@sheenaajay
Copy link
Contributor

Thank you @tomkrouper for submitting the PR.

@sheenaajay sheenaajay merged commit 16b1c8c into puppetlabs:master Jul 1, 2020
@tomkrouper tomkrouper deleted the modules-10723 branch July 1, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants