Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package provider and source #1314

Merged
merged 1 commit into from Jul 23, 2020

Conversation

fe80
Copy link
Contributor

@fe80 fe80 commented Jul 15, 2020

Hi,

I require this options for the commercial package. Oracle does not provide package repositories. We need to download the package and install with dpkg/rpm.

Test and validate on Ubuntu 18.04.

Regards,

@fe80 fe80 requested a review from a team as a code owner July 15, 2020 12:16
@puppet-community-rangefinder
Copy link

mysql::client is a class

Breaking changes to this file WILL impact these 14 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

mysql::client::install is a class

that may have no external impact to Forge modules.

mysql::server is a class

Breaking changes to this file WILL impact these 75 modules (exact match):
Breaking changes to this file MAY impact these 50 modules (near match):

mysql::server::install is a class

that may have no external impact to Forge modules.

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@fe80 fe80 force-pushed the feature/package_provider branch from 9424fe2 to 62e9e36 Compare July 15, 2020 14:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #1314 into master will increase coverage by 5.45%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
+ Coverage   50.23%   55.69%   +5.45%     
==========================================
  Files          22       22              
  Lines        1045     1045              
==========================================
+ Hits          525      582      +57     
+ Misses        520      463      -57     
Impacted Files Coverage Δ
lib/puppet/provider/mysql_user/mysql.rb 87.58% <40.00%> (ø)
...ppet/provider/mysql_login_path/mysql_login_path.rb 90.32% <0.00%> (+61.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b1c8c...62e9e36. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @fe80, this looks very nice! Thank you for your contribution! Cheers!

@daianamezdrea daianamezdrea merged commit 802a291 into puppetlabs:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants