Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package for python bindings on Ubuntu 20.04 #1323

Merged
merged 1 commit into from Nov 3, 2020

Conversation

tobias-urdin
Copy link
Contributor

The default python version on Ubuntu 20.04 is
python3 thus the current package is wrong.

This changes the package to use python3-mysqldb.

The default python version on Ubuntu 20.04 is
python3 thus the current package is wrong.

This changes the package to use python3-mysqldb.
@tobias-urdin tobias-urdin requested a review from a team as a code owner September 3, 2020 20:49
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sanfrancrisko
Copy link
Contributor

Closing and re-opening the PR to kick the tests again (some issue triggering from TravisCI directly)

@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@pmcmaw pmcmaw closed this Nov 2, 2020
@pmcmaw pmcmaw reopened this Nov 2, 2020
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@pmcmaw pmcmaw closed this Nov 2, 2020
@pmcmaw pmcmaw reopened this Nov 2, 2020
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@pmcmaw pmcmaw closed this Nov 2, 2020
@pmcmaw pmcmaw reopened this Nov 2, 2020
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@pmcmaw pmcmaw changed the base branch from master to main November 2, 2020 18:02
@pmcmaw pmcmaw closed this Nov 2, 2020
@pmcmaw pmcmaw reopened this Nov 2, 2020
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@pmcmaw pmcmaw closed this Nov 2, 2020
@pmcmaw pmcmaw reopened this Nov 2, 2020
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@pmcmaw
Copy link
Contributor

pmcmaw commented Nov 2, 2020

@tobias-urdin apologies for the opening and closing of your PR I was trying to get Travis passing as the following was merged: #1338 However I have hit new issues now but I am working on them.

@tobias-urdin
Copy link
Contributor Author

@pmcmaw No worries, thanks for fixing the failed testing! :)

@pmcmaw pmcmaw self-assigned this Nov 3, 2020
@pmcmaw pmcmaw added the bugfix label Nov 3, 2020
@pmcmaw
Copy link
Contributor

pmcmaw commented Nov 3, 2020

Travis is running green, although showing still in progress on the UI. Build can be seen here: https://travis-ci.org/github/puppetlabs/puppetlabs-mysql/builds/740943247

Merging.

Again @tobias-urdin I would like to thank you for your contribution to our module and your patience.

@pmcmaw pmcmaw merged commit 48a4298 into puppetlabs:main Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants