Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10790) - Setting logbin results in error Unknown variable: 'managed_dirs_path' #1325

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Sep 8, 2020

No description provided.

@pmcmaw pmcmaw requested a review from a team as a code owner September 8, 2020 18:23
@pmcmaw pmcmaw added the bugfix label Sep 8, 2020
@pmcmaw pmcmaw closed this Sep 22, 2020
@pmcmaw pmcmaw reopened this Sep 22, 2020
@puppet-community-rangefinder
Copy link

mysql::server::managed_dirs is a class

that may have no external impact to Forge modules.

This module is declared in 142 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@pmcmaw pmcmaw force-pushed the MODULES-10790 branch 2 times, most recently from 8d11d24 to 3bd32ac Compare October 6, 2020 14:54
@pmcmaw pmcmaw changed the title (MODULES-10790) - Add test to highlight failure (MODULES-10790) - Setting logbin results in error Unknown variable: 'managed_dirs_path' Oct 6, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@3288a87). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1325   +/-   ##
=======================================
  Coverage        ?   55.58%           
=======================================
  Files           ?       22           
  Lines           ?     1047           
  Branches        ?        0           
=======================================
  Hits            ?      582           
  Misses          ?      465           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3288a87...53da2db. Read the comment docs.

@daianamezdrea daianamezdrea merged commit 5c2572f into puppetlabs:main Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants