fixed character-set detection regex #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous regex matched COLLATE value instead of CHARACTER SET. For example: > CREATE DATABASE `test` /*!40100 DEFAULT CHARACTER SET utf8 COLLATE utf8_bin */ Returned utf8_bin instead of utf8 causing an unfortunate database refresh in my configuration. Fixed the regex by adding the optional presence of the COLLATE keyword.
|
For the record, the build problem isn't my code's fault:
|
hunner
added a commit
that referenced
this pull request
Jan 9, 2013
fixed character-set detection regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous regex matched COLLATE value instead of CHARACTER SET. For example:
Returned
utf8_bininstead ofutf8causing an unfortunate database refresh in my configuration. Fixed the regex by adding the optional presence of the COLLATE keyword.Tested to make sure that it worked on both cases (w/ and w/o COLLATE).