Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default MySQL version for FreeBSD #1360

Merged
merged 2 commits into from Jan 18, 2021
Merged

Set default MySQL version for FreeBSD #1360

merged 2 commits into from Jan 18, 2021

Conversation

olevole
Copy link
Contributor

@olevole olevole commented Jan 16, 2021

@olevole olevole requested a review from a team as a code owner January 16, 2021 14:57
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 143 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #1360 (7acb8b5) into main (a48c423) will decrease coverage by 5.42%.
The diff coverage is 46.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
- Coverage   55.75%   50.33%   -5.43%     
==========================================
  Files          22       22              
  Lines        1051     1055       +4     
==========================================
- Hits          586      531      -55     
- Misses        465      524      +59     
Impacted Files Coverage Δ
lib/facter/mysql_server_id.rb 87.50% <ø> (ø)
lib/facter/mysql_version.rb 100.00% <ø> (ø)
lib/facter/mysqld_version.rb 100.00% <ø> (ø)
.../puppet/functions/mysql/normalise_and_deepmerge.rb 0.00% <0.00%> (ø)
lib/puppet/functions/mysql/password.rb 0.00% <0.00%> (ø)
lib/puppet/functions/mysql/strip_hash.rb 0.00% <ø> (ø)
lib/puppet/functions/mysql_password.rb 0.00% <ø> (ø)
lib/puppet/provider/mysql.rb 37.50% <0.00%> (+0.51%) ⬆️
lib/puppet/provider/mysql_datadir/mysql.rb 0.00% <ø> (ø)
lib/puppet/provider/mysql_grant/mysql.rb 16.49% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b90c2...7acb8b5. Read the comment docs.

this fixes the error:
 Error: Services must specify a start command or a binary

Tested with: FreeBSD 13.0-ALPHA1
@david22swan david22swan merged commit 300b677 into puppetlabs:main Jan 18, 2021
@david22swan
Copy link
Member

@olevole
Thanks for the work you've put in.
The changes you've made look good to me so I've gone ahead and merged it.
Hope to see more from you in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants