Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IAC-1497) - Removal of unsupported translate dependency #1375

Merged

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan requested a review from a team as a code owner March 16, 2021 16:31
@CLAassistant
Copy link

CLAassistant commented Mar 16, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::bindings is a class

Breaking changes to this file WILL impact these 14 modules (exact match):
Breaking changes to this file MAY impact these 17 modules (near match):

mysql::bindings::client_dev is a class

that may have no external impact to Forge modules.

mysql::bindings::daemon_dev is a class

that may have no external impact to Forge modules.

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

mysql::server is a class

Breaking changes to this file WILL impact these 77 modules (exact match):
Breaking changes to this file MAY impact these 50 modules (near match):

mysql::server::backup is a class

Breaking changes to this file WILL impact these 4 modules (exact match):

This module is declared in 143 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

Codecov Report

Merging #1375 (340cad7) into main (7acb8b5) will increase coverage by 4.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
+ Coverage   50.33%   55.32%   +4.99%     
==========================================
  Files          22       22              
  Lines        1055     1052       -3     
==========================================
+ Hits          531      582      +51     
+ Misses        524      470      -54     
Impacted Files Coverage Δ
lib/facter/mysql_server_id.rb 37.50% <0.00%> (-50.00%) ⬇️
lib/puppet/provider/mysql_user/mysql.rb 87.41% <0.00%> (-0.18%) ⬇️
lib/puppet/provider/mysql_grant/mysql.rb 16.66% <0.00%> (+0.17%) ⬆️
...ppet/provider/mysql_login_path/mysql_login_path.rb 90.72% <0.00%> (+58.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af99b9...340cad7. Read the comment docs.

@david22swan david22swan force-pushed the IAC-1497/main/translate_removal branch from 340cad7 to 88cb36d Compare March 18, 2021 09:49
@david22swan david22swan force-pushed the IAC-1497/main/translate_removal branch from 88cb36d to 6649e45 Compare March 18, 2021 11:17
@daianamezdrea daianamezdrea merged commit bb9e0fc into puppetlabs:main Mar 19, 2021
@david22swan david22swan deleted the IAC-1497/main/translate_removal branch August 10, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants