Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-11115) add Rocky Linux 8 compatibility #1405

Merged
merged 1 commit into from Jul 5, 2021

Conversation

vchepkov
Copy link
Contributor

No description provided.

@vchepkov vchepkov requested a review from a team as a code owner June 26, 2021 13:22
@CLAassistant
Copy link

CLAassistant commented Jun 26, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 143 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ghoneycutt
Copy link
Contributor

Suggest adding this to the provision.yaml so acceptance testing shows this platform works.

@vchepkov
Copy link
Contributor Author

I don't mind, just don't know how to find out what images are available.
Vagrant rockylinux/8 is there

@pmcmaw pmcmaw changed the title (MODULES-11115) add Rocky Linux 8 support (MODULES-11115) add Rocky Linux 8 compatibility Jun 29, 2021
@pmcmaw
Copy link
Contributor

pmcmaw commented Jun 29, 2021

Hey @vchepkov

We would be more than happy to accept your PR (the code change) to make this module compatible with Rocky. However when adding to the metadata.json and provision.yaml it suggests that we would be supporting this OS which is something the team would not be able to do.

Note - I have updated your PR title to include compatibility rather than support.

@vchepkov
Copy link
Contributor Author

vchepkov commented Jul 1, 2021

@pmcmaw , would you like me to remove change to metadata.json? As long as module's manifest doesn't make any decision based on the metadata, it should be fine. Some modules do that, unfortunately, https://github.com/voxpupuli/puppet-yum/blob/master/manifests/init.pp#L108

@pmcmaw
Copy link
Contributor

pmcmaw commented Jul 1, 2021

Yeah none of our supported modules do that. If you remove the metadata change and just have the manifest change I will get it merged. There was a fix merged earlier for spec test failures so if you rebase they will pass. 👍

@pmcmaw pmcmaw added the feature label Jul 1, 2021
@vchepkov
Copy link
Contributor Author

vchepkov commented Jul 1, 2021

@pmcmaw , done

@pmcmaw pmcmaw merged commit 926ae6d into puppetlabs:main Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants