Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mysql::server::mysqltuner and show it as an example #1409

Merged

Conversation

ghoneycutt
Copy link
Contributor

Suggest moving mysql::server::mysqltuner to an example profile. It is a very simple piece of code that is not directly part of managing mysql and should not be part of the mysql module.

@ghoneycutt ghoneycutt requested a review from a team as a code owner June 29, 2021 01:58
@pmcmaw
Copy link
Contributor

pmcmaw commented Jul 5, 2021

This should go green if you rebase.

@ghoneycutt ghoneycutt force-pushed the move_tuner_to_example_profile branch 2 times, most recently from 2e8b98e to 46754aa Compare July 6, 2021 22:55
@ghoneycutt ghoneycutt changed the title WIP - move mysql::server::mysqltuner to an example profile Deprecate mysql::server::mysqltuner and show it as an example Jul 6, 2021
@ghoneycutt
Copy link
Contributor Author

@pmcmaw This is ready for merge

@daianamezdrea
Copy link
Contributor

Hi @ghoneycutt, I've merged your other PR, I'll merge this one too if you rebase it, thank you for your contributions! Cheers!

@ghoneycutt ghoneycutt force-pushed the move_tuner_to_example_profile branch from 46754aa to c85c02b Compare July 12, 2021 16:25
@ghoneycutt
Copy link
Contributor Author

Thanks @daianamezdrea , rebased

@daianamezdrea daianamezdrea merged commit f57de87 into puppetlabs:main Jul 13, 2021
@ghoneycutt ghoneycutt deleted the move_tuner_to_example_profile branch July 13, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants