Patch providers for absent my.cnf #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the /root/.my.cnf file does not exist but is specified by the `--defaults-file` argument, the mysql calls will fail. The `mysql::config` class creates this file, but if the custom resources are used without including our classes then it will still break. This allows users to use our custom resources without having to use our classes.
| @@ -14,10 +14,11 @@ | |||
| ) | |||
| @provider = provider_class.new(@resource) | |||
| Facter.stubs(:value).with(:root_home).returns(root_home) | |||
| File.stubs(:file?).with("#{root_home}/.my.cnf").returns(true) | |||
There was a problem hiding this comment.
There aren't any tests checking for the CONVERSE behavior (where --defaults-file wasn't being called). We should at least test that behavior.
|
Looks good with the new tests, I'll merge this in. |
glarizza
pushed a commit
that referenced
this pull request
Jan 11, 2013
Patch providers for absent my.cnf
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
pdksync - (maint) - Pdk Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the /root/.my.cnf file does not exist but is specified by the
--defaults-fileargument, the mysql calls will fail. Themysql::configclass creates this file, but if the custom resources areused without including our classes then it will still break.
This allows users to use our custom resources without having to use our
classes.