Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(IAC-1677) Fix issue with deprecated rspec #1414

Merged
merged 1 commit into from
Jul 5, 2021
Merged

(IAC-1677) Fix issue with deprecated rspec #1414

merged 1 commit into from
Jul 5, 2021

Conversation

ghoneycutt
Copy link
Contributor

No description provided.

@ghoneycutt ghoneycutt requested a review from a team as a code owner July 1, 2021 16:33
@ghoneycutt
Copy link
Contributor Author

@pmcmaw check out https://stackoverflow.com/questions/25041974/rspec-pending-results-in-falied-test

I put the comment back to what it was previously when this code was added.

@ghoneycutt
Copy link
Contributor Author

The failing test is a transitory issue downloading an rpm for acceptance testing and not applicable for this change.

@pmcmaw
Copy link
Contributor

pmcmaw commented Jul 5, 2021

@ghoneycutt thats interesting! Thanks for that! :-)

@pmcmaw
Copy link
Contributor

pmcmaw commented Jul 5, 2021

Merging, 1 failure is a transient error.

@pmcmaw pmcmaw merged commit de48b9c into puppetlabs:main Jul 5, 2021
@pmcmaw pmcmaw added the bugfix label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmcmaw pmcmaw pmcmaw approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghoneycutt @pmcmaw