Combine multiple grants into one while checking state #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fuyar
force-pushed
the
MODULES-10856
branch
2 times, most recently
from
cb911e0
to
1927162
Compare
|
Same as others opened PRs, those failing tests are not my failures, it is RPM dependency related. |
|
Hello @fuyar, sorry for the late answer but our team went through some transformations, can you rebase your PR in order to have everything green and ready to merge? Thank you and sorry again |
daianamezdrea
approved these changes
Nov 15, 2021
|
Great ! Thanks @daianamezdrea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every grant line stands for itself, this isnt corrent since MySQL can split these up into multiple GRANT statements. This change combines them before checking for diff
Fixes: https://tickets.puppetlabs.com/browse/MODULES-10856
All credits goes to https://github.com/fionera, just added a test.