(Bugfix) Grant privileges idempotency Fix #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the Ubuntu 20.04 spec testing was failing two test cases at mysql_grant_spec. One of them was a simple mismatch between the expected stdout and actual stdout of the test case, and the other had to do with a misbehaviour from the module at the time of granting privileges to users. The module, upon instructed to grant 'ALL' pivileges to the user, creates and array that contains both 'ALL' and all dynamic privileges and passes that array as the parameter for privilege granting, causing an error in idempotency. This commit aims to the previously mentioned errors. The first error is a simple 'expected message' adjust whereas for the second issue, a temporary workaround that removes the duplicated dynamic privileges reference has been implemented. In the future, the issue should be assessed and a fix that actually modifies the behaviour of the module to avoid such duplication should be implemented.
LukasAud
changed the title
Edited a comment to describe better the issue present in the module.
Edited a comment to describe better the issue present in the module.
Small modification to the comment describing the issue.
david22swan
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the Ubuntu 20.04 spec testing was failing two
test cases at mysql_grant_spec. One of them was a simple mismatch
between the expected stdout and actual stdout of the test case, and the
other had to do with a misbehaviour from the module at the time of
retrieving privileges from users. In the last MySQL version, the module,
upon retrieving privileges from an user, creates and array that contains
both 'ALL' and all dynamic privileges which is later used to check for
idempotency in certain test cases, causing an error in idempotency.
This commit aims to the previously mentioned errors. The first error is
a simple 'expected message' adjust whereas for the second issue, a
temporary workaround that removes the additional dynamic privileges
so that testing does not fail.
In the future, the issue should be assessed and a fix that actually
modifies the behaviour of the module to account for such processing of
privileges should be implemented.