Make /etc/.my.conf configurable #147

Closed
wants to merge 1 commit into from

2 participants

@guilhermeblanco

No description provided.

@apenney

I'm not opposed to this feature but I'm not sure I like the parameter name. Would it be possible to redo this PR with the param name "config_template" or something to make it clear what this does. I would also appreciate it if you could make a couple of quick rspec-puppet tests that ensure this functionality works if you change the name of the template.

@apenney

Hi,

I've recently merged in a very large changeset that completely redesigns this module. As a result I'm afraid this PR is no longer mergeable and possibly no longer valid (sorry, mass message for all PRs) due to the changes to binding and the removal of most of the parameters for my.cnf (as it's handed by an override hash currently).

I'm going to close all existing PRs that can't be merged and ask you to take a look at rebasing them against master or redeveloping them against master if the feature is still important to you. I hope that many of the existing PRs won't be needed in the refactoring!

Thanks for your patience everyone, I know this is pain.

@apenney apenney closed this Sep 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment