Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IAC-1595) MySQL maintenance #1472

Merged
merged 3 commits into from
May 24, 2022
Merged

(IAC-1595) MySQL maintenance #1472

merged 3 commits into from
May 24, 2022

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented May 24, 2022

Prior to this commit, MySQL module had the entirety of the Debian OS
family disabled due to provisioning issues at cloud level. JIRA ticket
IAC-1595 reported this behaviour. In addition, Debian 11 was reported
to have an unfinished implementation.

This commit was aimed at re-enabling the debian systems and
troubleshooting the failing ones. As well as adding the missing
configuration for Debian 11.

During this commit, it was established that the best way to troubleshoot
the debian provisioning issues was to switch the provisioning service to
GCP. Upon fixing the provisioning issues, a number of test error cases
related to privileges and bad locale variables were reported and those
were addressed as well.

Finally, some minor maintenance changes were applied as well.
Issues created:
#1473
#1474

Prior to this commit, MySQL module had the entirety of the Debian OS
family disabled due to provisioning issues at cloud level. JIRA ticket
IAC-1595 reported this behaviour. In addition, Debian 11 was reported
to have an unfinished implementation.

This commit was aimed at re-enabling the debian systems and
troubleshooting the failing ones. As well as adding the missing
configuration for Debian 11.

During this commit, it was established that the best way to troubleshoot
the debian provisioning issues was to switch the provisioning service to
GCP. Upon fixing the provisioning issues, a number of test error cases
related to privileges and bad locale variables were reported and those
were addressed as well.

Finally, some minor maintenance changes were applied as well.
@LukasAud LukasAud requested a review from a team as a code owner May 24, 2022 10:45
@LukasAud LukasAud self-assigned this May 24, 2022
@puppet-community-rangefinder
Copy link

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

mysql::server is a class

Breaking changes to this file WILL impact these 77 modules (exact match):
Breaking changes to this file MAY impact these 49 modules (near match):

This module is declared in 140 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud LukasAud mentioned this pull request May 24, 2022
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a few small questions but otherwise everything look's good.

.github/workflows/nightly.yml Show resolved Hide resolved
.github/workflows/pr_test.yml Show resolved Hide resolved
lib/puppet/provider/mysql_grant/mysql.rb Show resolved Hide resolved
spec/acceptance/04_mysql_backup_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/04_mysql_backup_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments

spec/acceptance/types/mysql_login_path_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/04_mysql_backup_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chelnak
Copy link
Contributor

chelnak commented May 24, 2022

LGTM

exciting

@LukasAud LukasAud merged commit f3af12f into main May 24, 2022
@LukasAud LukasAud deleted the IAC-1595-MySQL-maintenance branch May 24, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants