Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-173) - Updating deprecated facter instances #1501

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

jordanbreen28
Copy link
Contributor

Prior to this PR, this module contained instances of Facter::Util::Resolution.exec and Facter::Util::Resolution.which, which are deprecated. This PR aims to replace these exec helpers with their supported Facter::Core::Execution counterparts.

This PR:

Replaces all Facter::Util::Resolution instances with corresponding Facter::Core::Execution exec helpers

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner October 13, 2022 15:43
@jordanbreen28 jordanbreen28 force-pushed the cont-173/main/update_deprecated_facter branch 2 times, most recently from 16f7461 to 5147c13 Compare October 14, 2022 12:58
Prior to this PR, this module contained instances of Facter::Util::Resolution.exec and Facter::Util::Resolution.which, which are deprecated.
This PR aims to replace these exec helpers with their supported Facter::Core::Execution counterparts.

This PR:

Replaces all Facter::Util::Resolution instances with corresponding Facter::Core::Execution exec helpers
@jordanbreen28 jordanbreen28 force-pushed the cont-173/main/update_deprecated_facter branch from 5147c13 to ff4028b Compare October 14, 2022 13:00
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@GSPatton GSPatton merged commit 870e44c into main Oct 14, 2022
@GSPatton GSPatton deleted the cont-173/main/update_deprecated_facter branch October 14, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants