do not emit other ssl directives when ssl = false #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for newer versions of MariaDB, see issue puppetlabs#1509
|
Hi, @kjetilho. Thanks for your contribution. We are currently investigating the issue you are trying to address. Unfortunately, it doesnt seem like our test cases cover this scenario so we will need to investigate a bit further to ensure that your PR does not have any unexpected side effect. Meanwhile, could you implement a test case for your change? |
|
something like the above? |
|
Yes, that should be enough. Thanks for your contribution. We will merge as soon as we finish testing it on our side. |
anarcat
referenced
this pull request
Dec 20, 2022
Prior to this commit there was a possibility that malformed strings could be passed in to the resource. This could lead to unsafe executions on a remote system. The parameters that are susceptible are `install_secret_file`. This commit fixes the above by adding validation to ensure the given values confirm to expectation. `secret_file` is validated with a regular expression that ensures the given value is a valid path.
This was referenced Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for newer versions of MariaDB, see issue #1509