Use $root_home for .my.cnf #153

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@paramite
Contributor

File .my.cnf should not use hardcoded /root path

@bodepd
Contributor
bodepd commented Mar 21, 2013

where does root_home come from?

@derekhiggins
Contributor

@bodepd

It looks like root_home is a fact that is in stdlib
https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/lib/facter/root_home.rb

Stdlib is already needed by this module, and this fact is currently used in some of the providers e.g.
https://github.com/puppetlabs/puppetlabs-mysql/blob/master/lib/puppet/provider/database_grant/mysql.rb#L200

@apenney
Contributor
apenney commented Jul 2, 2013

Would it be possible for you to take a look at the broken tests for this PR? I suspect the issue is as simple as needing to set root_home in :facts in the tests so it correctly uses /root/ during testing. If the tests get fixed I can merge this.

@paramite
Contributor
paramite commented Jul 4, 2013

Sure, will check that

@paramite
Contributor
paramite commented Jul 8, 2013

Created new pull request with tests fixed.

#214

@paramite paramite closed this Jul 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment