Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CONT-359) Syntax update #1532

Merged
merged 5 commits into from
Feb 24, 2023
Merged

(CONT-359) Syntax update #1532

merged 5 commits into from
Feb 24, 2023

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented Jan 25, 2023 •
edited
Loading

Code now compliant with rules regarding:

legacy facts
parameter datatypes
parameter documentation
top-scope facts

@LukasAud
(CONT-359) Syntax update
08a16b2 
Code now compliant with rules regarding:

legacy facts
@LukasAud LukasAud force-pushed the CONT-359-Syntax_update branch 3 times, most recently from ee40ce5 to 89a62b9 Compare February 1, 2023 13:21
@LukasAud LukasAud marked this pull request as ready for review February 6, 2023 14:13
@LukasAud LukasAud requested a review from a team as a code owner February 6, 2023 14:13
@smortex smortex mentioned this pull request Feb 22, 2023
Closed
smortex
smortex reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 it seems like I had a few more legacy facts removed in /spec/ in #1535

manifests/params.pp Outdated Show resolved Hide resolved
smortex
smortex approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

david22swan
david22swan approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit c55e7a7 into main Feb 24, 2023
@david22swan david22swan deleted the CONT-359-Syntax_update branch February 24, 2023 14:41
@jdyb
Copy link

jdyb commented Mar 6, 2023 •
edited
Loading

Was it intentional to change Mysql::Server parameter package_ensure to no longer allow latest ?
It used to work for us and when we updated the module we hit the type restriction.
(I was not sure if this deserved an issue or not, if it is a bug I can probably submit a mr. to fix it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LukasAud @jdyb @smortex @david22swan @pmcmaw