Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql::server: Implement reload_on_config_change #1551

Merged
merged 1 commit into from
Mar 28, 2023
Merged

mysql::server: Implement reload_on_config_change #1551

merged 1 commit into from
Mar 28, 2023

Conversation

bastelfreak
Copy link
Collaborator

No description provided.

@bastelfreak bastelfreak requested a review from a team as a code owner March 28, 2023 08:10
@puppet-community-rangefinder
Copy link

mysql::server is a class

Breaking changes to this file WILL impact these 79 modules (exact match):
Breaking changes to this file MAY impact these 49 modules (near match):

mysql::server::service is a class

that may have no external impact to Forge modules.

This module is declared in 140 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@bastelfreak
Copy link
Collaborator Author

I was quite sure that the module has an option to restart the mysql on config changed, but I didn't find anything.

GSPatton
GSPatton previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good

GSPatton
GSPatton approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@GSPatton GSPatton merged commit 14aef71 into puppetlabs:main Mar 28, 2023
@cruelsmith
Copy link
Contributor

While reviewing the changes from v14.0.0 this one here but i do not get the point because there already exist this:

puppetlabs-mysql/manifests/server.pp

Lines 41 to 42 in f47bd78

# @param restart
# Whether the service should be restarted when things change. Valid values are `true`, `false`. Defaults to `false`.

So this change added a redundant option to enable a restart of the service.

@bastelfreak Should be this MR maybe reverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSPatton GSPatton GSPatton approved these changes

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bastelfreak @cruelsmith @GSPatton @david22swan @ia-content