Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move static data from params to server class #1552

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

bastelfreak
Copy link
Collaborator

This enables puppet-strings to pick up the data.

@bastelfreak bastelfreak requested a review from a team as a code owner March 28, 2023 08:30
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

mysql::server is a class

Breaking changes to this file WILL impact these 79 modules (exact match):
Breaking changes to this file MAY impact these 49 modules (near match):

This module is declared in 140 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@bastelfreak bastelfreak force-pushed the reference branch 2 times, most recently from 9ad9528 to cc19cdf Compare April 4, 2023 07:18
This enables puppet-strings to pick up the data.
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Imo, params should only contain variables used in multiple manifests, or ones that vary depending on the OS or other facts

@david22swan david22swan merged commit c0954b0 into puppetlabs:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants