Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-789) Add Support for Puppet 8 / Drop Support for Puppet 6 #1557

Merged
merged 23 commits into from
Apr 17, 2023

Conversation

david22swan
Copy link
Member

No description provided.

New Versions:
rubocop = 1.48.1
rubocop-performance = 1.16.0
rubocop-rspec = 2.19.0
@david22swan david22swan force-pushed the CONT-789/main/puppet_8 branch from 1624a43 to 878476c Compare April 11, 2023 15:00
@david22swan david22swan force-pushed the CONT-789/main/puppet_8 branch from 5623cc8 to 5459176 Compare April 11, 2023 15:51
- Layout/ArgumentAlignment
- Layout/BeginEndAlignment
- Layout/ClosingHeredocIndentation
- Layout/EmptyLineAfterGuardClause
- Layout/HashAlignment
- Layout/HeredocIndentation
- Layout/LineEndStringConcatenationIndentation
- Layout/SpaceInsideArrayLiteralBrackets
- Lint/RedundantCopEnableDirective
- RSpec/EmptyLineAfterExample
@david22swan david22swan force-pushed the CONT-789/main/puppet_8 branch 2 times, most recently from 9ab41b1 to ed0cef5 Compare April 12, 2023 10:32
- RSpec/EmptyLineAfterExampleGroup
- RSpec/EmptyLineAfterHook
- RSpec/ExcessiveDocstringSpacing
- RSpec/ImplicitSubject
- Style/AccessorGrouping
- Style/Encoding
- Style/ExplicitBlockArgument
- Style/FetchEnvVar
- Style/HashAsLastArrayItem
- Style/IfUnlessModifier
@david22swan david22swan force-pushed the CONT-789/main/puppet_8 branch from ed0cef5 to a1b3132 Compare April 12, 2023 10:46
- Style/NegatedIfElseCondition
- Style/RedundantAssignment
- Style/RedundantRegexpEscape
- Style/RedundantStringEscape
- Style/RescueStandardError
- Style/SoleNestedConditional
- Style/TernaryParentheses
- Style/TrailingCommaInHashLiteral
- Performance/MapCompact
- Performance/StringInclude
- RSpec/BeEq & RSpec/BeNil
- RSpec/VerifiedDoubleReference
- Style/CaseLikeIf
- Style/CommentedKeyword
- Style/GlobalStdStream
- Style/NumericPredicate
- Style/StringConcatenation
- Style/SymbolProc
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants