-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CONT-789) Add Support for Puppet 8 / Drop Support for Puppet 6 #1557
Merged
LukasAud
merged 23 commits into
puppetlabs:main
from
david22swan:CONT-789/main/puppet_8
Apr 17, 2023
Merged
(CONT-789) Add Support for Puppet 8 / Drop Support for Puppet 6 #1557
LukasAud
merged 23 commits into
puppetlabs:main
from
david22swan:CONT-789/main/puppet_8
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Versions: rubocop = 1.48.1 rubocop-performance = 1.16.0 rubocop-rspec = 2.19.0
1624a43
to
878476c
Compare
5623cc8
to
5459176
Compare
- Layout/ArgumentAlignment - Layout/BeginEndAlignment - Layout/ClosingHeredocIndentation - Layout/EmptyLineAfterGuardClause - Layout/HashAlignment
- Layout/HeredocIndentation - Layout/LineEndStringConcatenationIndentation - Layout/SpaceInsideArrayLiteralBrackets - Lint/RedundantCopEnableDirective - RSpec/EmptyLineAfterExample
9ab41b1
to
ed0cef5
Compare
- RSpec/EmptyLineAfterExampleGroup - RSpec/EmptyLineAfterHook - RSpec/ExcessiveDocstringSpacing - RSpec/ImplicitSubject - Style/AccessorGrouping
- Style/Encoding - Style/ExplicitBlockArgument - Style/FetchEnvVar - Style/HashAsLastArrayItem - Style/IfUnlessModifier
ed0cef5
to
a1b3132
Compare
- Style/NegatedIfElseCondition - Style/RedundantAssignment - Style/RedundantRegexpEscape - Style/RedundantStringEscape - Style/RescueStandardError
- Style/SoleNestedConditional - Style/TernaryParentheses - Style/TrailingCommaInHashLiteral
- Performance/MapCompact - Performance/StringInclude - RSpec/BeEq & RSpec/BeNil
- RSpec/VerifiedDoubleReference - Style/CaseLikeIf - Style/CommentedKeyword
- Style/GlobalStdStream - Style/NumericPredicate - Style/StringConcatenation - Style/SymbolProc
LukasAud
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.