mysql::dev installs developement libraries. #160

Closed
wants to merge 1 commit into
from

2 participants

@Aethylred

Currently just has myslqclient set up as an example with the Debian OS family.

This is a proposed pattern for installing mysql development libraries.

mysql::dev has a parameter for each library configured, and an ensure statement is passed to that parameter, i.e. absent, present, or a version string. This is checked to see if an appropriate package variable has been set in mysql::params by OS or OS Family. The ensure statement is then passed to the package.

@apenney apenney commented on the diff Jul 2, 2013
README.md
@@ -91,6 +91,16 @@ Creates a database with a user and assign some privileges.
grant => ['all'],
}
+### mysql::dev
+Installes mysql development libraries, each library is represented by a parameter which is passed a valid `ensure` statement, i.e. `present`,`absent`, or a version string.
@apenney
apenney added a line comment Jul 2, 2013

Minor thing but a tiny typo in Installes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@apenney apenney commented on the diff Jul 2, 2013
README.md
@@ -91,6 +91,16 @@ Creates a database with a user and assign some privileges.
grant => ['all'],
}
+### mysql::dev
+Installes mysql development libraries, each library is represented by a parameter which is passed a valid `ensure` statement, i.e. `present`,`absent`, or a version string.
+
+ class { 'mysql::dev':
+ mysqlclient => present,
+ }
+
+#### Current development librarires supported:
@apenney
apenney added a line comment Jul 2, 2013

librarires should be libraries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@apenney

Generally I'm OK with this PR but I would like to see better defaults so that:

include 'mysql::dev' <-- gets me all dev packages for that OS.

I'd default to setting everything to present so that people only need to override if they really need a specific version. I would also like to see an additional mysql_dev_spec.rb created that tests this class with:

  • defaults
  • specific version.
  • absent.

Just to round out the PR so we can ensure it stays working in future.

Thanks!

@Aethylred Aethylred mysql::dev installs developement libraries. Currently just has myslqc…
…lient set up as an example with the Debian OS family
e7ab5d1
@Aethylred

ah, I've just rebased over the current master. I'm not currently in a place to work on the improvement's you're requested.

@apenney

Hi,

I've recently merged in a very large changeset that completely redesigns this module. As a result I'm afraid this PR is no longer mergeable and possibly no longer valid (sorry, mass message for all PRs) due to the changes to binding and the removal of most of the parameters for my.cnf (as it's handed by an override hash currently).

I'm going to close all existing PRs that can't be merged and ask you to take a look at rebasing them against master or redeveloping them against master if the feature is still important to you. I hope that many of the existing PRs won't be needed in the refactoring!

Thanks for your patience everyone, I know this is pain.

@apenney apenney closed this Sep 23, 2013
@Aethylred

It looks like the new version includes the language bindings that this PR was trying to bring in.

@Aethylred Aethylred deleted the nesi:mysql-dev branch Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment