Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add server-id in mysql::server configuration #164

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

Used in replication config

@hunner hunner commented on an outdated diff Apr 25, 2013

templates/my.cnf.erb
@@ -21,6 +21,10 @@ skip-external-locking
bind-address = <%= bind_address %>
<% end %>
+<% if server_id %>
@hunner

hunner Apr 25, 2013

Member

Could you please add -%> closing tags here and below to avoid extra linebreaks in the resulting config? Thanks.

@hunner hunner commented on an outdated diff Apr 25, 2013

templates/my.cnf.erb
@@ -21,6 +21,10 @@ skip-external-locking
bind-address = <%= bind_address %>
<% end %>
+<% if server_id %>
+server-id = <%= server_id %>
+<% end %>
Contributor

apenney commented Jul 2, 2013

Hi,

I'm going to close this in favor of #194 so that we have a single PR dealing with replication. I appreciate you taking the time to submit this and apologize for taking so long to get around to dealing with this. If you want to check out #194 and comment on anything it's missing there I'd appreciate it.

@apenney apenney closed this Jul 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment