(WIP) #20562: Minor fix for ordering #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by hand and then you change your mysql::server entry to match. If you also change any mysql::db entries at the same time this causes those to be attempted before your /root/.my.cnf is updated. I can't add rspec testing for this until rodjek/rspec-puppet#106 is merged.
|
The patch blocking the merge of your fix ( rodjek/rspec-puppet#106 ) is stalled for now because rodjek does not have enough free time at the moment. I'm willing to help but it will take me some time to come up with something sensible ;-) Would you consider merging the patch and maybe open a new pull request dedicated to the associated test ? |
|
As I wrote this I think I'm going to merge it in for now, I don't want us to wait for eternity for rspec-puppet changes. |
apenney
added a commit
that referenced
this pull request
Jul 2, 2013
(WIP) #20562: Minor fix for ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small fix for the case where the root password has been changed by hand and then you change your mysql::server entry to match. If you also change any mysql::db entries at the same time this causes those to be attempted before your /root/.my.cnf is updated.
NOTE:
I can't add rspec testing for this until rodjek/rspec-puppet#106 is merged. I would prefer not to merge this until we add those ordering tests, but I wanted to at least get a PR up for the person with the issue.