Remove redundant hard coded replication parameters #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following new `mysql` class replication parameters were added in 0.8.0, however the existing hard coded parameters were not removed from the my.conf.erb template: - `expire_logs_days` - `max_binlog_size`
|
I can't believe we never noticed this. I need to take a day or two and sit down and tear into the specs here. We should probably test each parameter somewhere so this kind of thing doesn't happen again. Thanks for catching this. |
apenney
pushed a commit
that referenced
this pull request
Jul 15, 2013
Remove redundant hard coded replication parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following new
mysqlclass replication parameters were added in 0.8.0, however the existing hard coded parameters were not removed from the my.conf.erb template:expire_logs_daysmax_binlog_sizeSorry about the noise with the previous pull request, I saw it failed the tests because I moved the parameters. I didn't see any test for these lines which would be removed so this should be OK. This is my first ever pull request so I was always bound to make a mistake!