Skip to content

Bug #11375: puppetlabs-mysql fails on CentOS/RHEL #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2011

Conversation

justintime
Copy link

@@ -44,6 +44,11 @@
ensure => directory,
mode => '755',
}
file { '/etc/mysql/conf.d':
ensure => directory,
require => File['/etc/mysql'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This require isn't necessary. Implicit dependencies will take care of this.

@justinellison
Copy link
Contributor

@ccaum - good catch, require removed.

@ghoneycutt - I'm not seeing conf.d on any RH systems, but this module tries to include that dir via my.cnf.erb. My commit was an attempt to fix that.

However, that got me digging, and I think I've found another problem. At least on my CentOS 6 systems, the mysql-server rpm doesn't setup /etc/mysql either, the binary is looking for /etc/my.cnf.

So, I think we should maybe add a $config_file var to params.pp to do this all a bit more intelligently perhaps? Is this a separate issue altogether?

@justinellison
Copy link
Contributor

I'm in #puppet as justintime for the next hour if you need me real-time.

@ccaum
Copy link
Contributor

ccaum commented Dec 14, 2011

Would it make sense to symlink /etc/my.cnf to /etc/mysql/my.cnf on CentOS 6 systems?

@justinellison
Copy link
Contributor

The only problem is that I'm pretty sure /etc/my.cnf and /etc/mysql/my.cnf differ on CentOS and Ubuntu. What about using a variable in params.pp and using file_line() from stdlib to just make sure that our /etc/mysql/conf.d/ directory is included?

@justinellison
Copy link
Contributor

Umm, yuck: http://pastebin.com/mcK3U1XH

That's a diff of CentOS6 vs Debian 6.0.2

ccaum added a commit that referenced this pull request Dec 14, 2011
Bug #11375: puppetlabs-mysql fails on CentOS/RHEL

Reviewed by Carl Caum <carl@puppetlabs.com>
@ccaum ccaum merged commit 7957912 into puppetlabs:master Dec 14, 2011
pmcmaw pushed a commit to pmcmaw/puppetlabs-mysql that referenced this pull request Mar 3, 2021
…l-task-management

(MODULES-6800) Add Windows service management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants