Support multiple lines of the same option

[fridim]

Some MySQL options need to be passed several time. Example :

http://dev.mysql.com/doc/refman/5.5/en/replication-options-slave.html#option_mysqld_replicate-do-db

This is currently impossible with the override_options. This patch allows to
pass array as value. Example :

override_options => {
  'client' => {
    'password' => 'xxx',
  },
  'mysqld' => {
    'bind_address'    => '0.0.0.0',
    'replicate-do-db' => ['base1', 'base2', 'base3'],
  },
}

Which will be evaluated into :

[client]
password = xxx

[mysqld]
bind_address = 0.0.0.0
replicate-do-db = base1
replicate-do-db = base2
replicate-do-db = base3

[igalic]

Do we have a safe list of options which can occur multiple times?

[fridim]

Not sure if such a list exists. I asked #mariadb on IRC, they don't think so.

At least 9 of replication-related options can have multiple instances:

• replicate-wild-ignore-table
• replicate-do-db
• replicate-wild-do-table
• replicate-ignore-db
• replicate-do-table
• replicate-ignore-table
• replicate-rewrite-db
• binlog-do-db
• binlog-ignore-db

[igalic]

can you please add a test and documentation?

[fridim]

sure

[fridim]

Commit updated with doc and test.

Is the test in the right place ? Let me know (was not sure about it).

[igalic]

I'm mildly confused that we still have spec/system, since after @apenney switched us over to beaker

Generally there are two kinds of tests that we have "system" tests (which are now relocated in spec/acceptance) and "normal" rspec puppet tests (everything else in spec/). Please look at our sister-module's contribution guidelines for more info.

[fridim]

Tests added. As suggested on IRC, added test for

• spec/classes/mysql_server_spec.rb
• both spec/system/mysql_server_spec.rb and spec/acceptance/mysql_server_spec.rb

[apenney]

Thanks for the additional tests! I should probably just yank out spec/system/ now, I just wanted to be sure we were done with the beaker stuff before doing so. I'll take a look at this, mysql makes me sad with how complex my.cnf can be. :)

[fridim]

Just rebased from puppetlabs-mysql/master

[apenney]

Thanks for this, I had no idea this was allowed in my.cnf, very cool. :)