mysql_deepmerge should treat underscore and dash equivalently, as mysql does #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,8 @@ module Puppet::Parser::Functions | |||
|
|
|||
| When there is a duplicate key that is a hash, they are recursively merged. | |||
| When there is a duplicate key that is not a hash, the key in the rightmost hash will "win." | |||
| When there are conficting uses of dashes and underscores in two keys (which mysql would otherwise equate), | |||
| the rightmost style will win. | |||
|
To avoid ruining the symmetry of the three Whens. It looked like the previous two Whens were consciously not wrapped so I kept that, but then some people don't like long lines so I indented it. Which way would you like it? I wasn't sure what format the docs were it of if they were parsed by some tool or other. |
|
Oh MySQL, the most complex of beasts. |
apenney
pushed a commit
that referenced
this pull request
Jan 24, 2014
mysql_deepmerge should treat underscore and dash equivalently, as mysql does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.