Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle mysql compiled without ssl #477

Merged
merged 3 commits into from
Mar 6, 2014
Merged

Conversation

globin
Copy link
Contributor

@globin globin commented Feb 28, 2014

mysql doesn't allow ssl=true/false in my.cnf if it hasn't been compiled
with ssl, therefor add a new parameter ssl-disable which makes sure the
template doesn't write anything with ssl to the config.

mysql doesn't allow ssl=true/false in my.cnf if it hasn't been compiled
with ssl, therefor add a new parameter ssl-disable which makes sure the
template doesn't write anything with ssl to the config.
@igalic
Copy link
Contributor

igalic commented Mar 2, 2014

_o

What distro disables SSL in this day and age?!

@globin
Copy link
Contributor Author

globin commented Mar 2, 2014

We are sadly forced to use SLES 11 SP1 with a totally ancient mysql version for some things.. 💣

@igalic
Copy link
Contributor

igalic commented Mar 3, 2014

Would be nice to get a test case for this.
After all we do have a SLES11 node

@globin
Copy link
Contributor Author

globin commented Mar 4, 2014

Added test case and warning if ssl-disable is set.

@igalic
Copy link
Contributor

igalic commented Mar 5, 2014

I meant a spec/acceptance test, one that directly tests it against SLES11.

@globin
Copy link
Contributor Author

globin commented Mar 5, 2014

I think the problem is that we use a very awkward repository for the mysql server which has this problem. I have no idea how to reproduce that in the test cases.

@igalic
Copy link
Contributor

igalic commented Mar 6, 2014

ACK.
I'm pretty and sure you have very valid reasons for doing so, meanwhile, let's merge this!

igalic added a commit that referenced this pull request Mar 6, 2014
handle mysql compiled without ssl
@igalic igalic merged commit 501448c into puppetlabs:master Mar 6, 2014
@globin
Copy link
Contributor Author

globin commented Mar 6, 2014

👍

@gabrielbull
Copy link

This commit is breaking the module. Has it been properly tested?

@igalic
Copy link
Contributor

igalic commented Mar 6, 2014

I did test it before, running spec/acceptance tests locally, which succeeded. So I guess we're missing more tests. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants