-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle mysql compiled without ssl #477
Conversation
mysql doesn't allow ssl=true/false in my.cnf if it hasn't been compiled with ssl, therefor add a new parameter ssl-disable which makes sure the template doesn't write anything with ssl to the config.
What distro disables SSL in this day and age?! |
We are sadly forced to use SLES 11 SP1 with a totally ancient mysql version for some things.. 💣 |
Would be nice to get a test case for this. |
Added test case and warning if ssl-disable is set. |
I meant a spec/acceptance test, one that directly tests it against SLES11. |
I think the problem is that we use a very awkward repository for the mysql server which has this problem. I have no idea how to reproduce that in the test cases. |
ACK. |
handle mysql compiled without ssl
👍 |
This commit is breaking the module. Has it been properly tested? |
I did test it before, running spec/acceptance tests locally, which succeeded. So I guess we're missing more tests. :( |
mysql doesn't allow ssl=true/false in my.cnf if it hasn't been compiled
with ssl, therefor add a new parameter ssl-disable which makes sure the
template doesn't write anything with ssl to the config.