Require title of mysql_grant resource to match form user/table #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmurphy when you rebase your commit, it should pass Travis tests. (I wonder now if that's the reason that my root@ hacks for mariaDB are not idempotent… https://tickets.puppetlabs.com/browse/MODULES-151 … I need to dig into this a little more ._.) |
This addresses https://tickets.puppetlabs.com/browse/MODULES-1040. The user parameter is required to have the form username@host. A grant is identified in the instances method by a name of the form username@host/table. The resource will fail to be identified as already existing if the name given to the resource does not match this form.
apenney
pushed a commit
that referenced
this pull request
Jun 5, 2014
Require title of mysql_grant resource to match form user/table
eputnam
added a commit
to eputnam/puppetlabs-mysql
that referenced
this pull request
Jun 27, 2017
Users are running into an issue where fails because there is a global name validation using properties that only exist in a compiled catalog and not in the naked type that is instantiated during a run. This moves name validation into the parameter in the mysql_grant type. See also puppetlabs#522
eputnam
added a commit
to eputnam/puppetlabs-mysql
that referenced
this pull request
Jun 27, 2017
Users are running into an issue where \`puppet resource mysql_grant\` fails because there is a global name validation using properties that only exist in a compiled catalog and not in the naked type that is instantiated during a \`puppet resource\` run. This moves name validation into the \`name\` parameter in the mysql_grant type. See also puppetlabs#522
eputnam
added a commit
to eputnam/puppetlabs-mysql
that referenced
this pull request
Jun 27, 2017
Users are running into an issue where \`puppet resource mysql_grant\` fails because there is a global name validation using properties that only exist in a compiled catalog and not in the naked type that is instantiated during a \`puppet resource\` run. This moves name validation into the \`name\` parameter in the mysql_grant type. See also puppetlabs#522
eputnam
added a commit
to eputnam/puppetlabs-mysql
that referenced
this pull request
Jun 27, 2017
Users are running into an issue where \`puppet resource mysql_grant\` fails because there is a global name validation using properties that only exist in a compiled catalog and not in the naked type that is instantiated during a \`puppet resource\` run. self[:user] and self[:table] are nil in this use case so validation uses a regex instead. Puppet can help with format but the user needs to be responsible for the content of the name. This commit also moves the name validation into the \`name\` parameter in the mysql_grant type. See also puppetlabs#522
eputnam
added a commit
to eputnam/puppetlabs-mysql
that referenced
this pull request
Jun 27, 2017
Users are running into an issue where \`puppet resource mysql_grant\` fails because there is a global name validation using properties that only exist in a compiled catalog and not in the naked type that is instantiated during a \`puppet resource\` run. self[:user] and self[:table] are nil in this use case so validation uses a regex instead. Puppet can help with format but the user needs to be responsible for the content of the name. This commit also moves the name validation into the \`name\` parameter in the mysql_grant type. See also puppetlabs#522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://tickets.puppetlabs.com/browse/MODULES-1040.
The user parameter is required to have the form username@host. A grant
is identified in the instances method by a name of the form
username@host/table. The resource will fail to be identified as already
existing if the name given to the resource does not match this form.
I'm happy to dig into this more if there are other suggestions for how to fix this.