(#13203) Add ssl support #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a ssl parameter to the mysql::config class. Setting ssl to true adds the following parameters to the template. ssl_ca - path to ssl-ca ssl_cert - path to ssl-cert ssl_key - path to ssl-key
| @@ -34,7 +38,11 @@ | |||
| $service_name = $mysql::params::service_name, | |||
| $config_file = $mysql::params::config_file, | |||
| $socket = $mysql::params::socket, | |||
| $datadir = $mysql::params::datadir | |||
| $datadir = $mysql::params::datadir, | |||
There was a problem hiding this comment.
why use defaults from the params namespace if the values do not change based on OS? Why not just specify the defaults in the class declaration?
There was a problem hiding this comment.
Hi @bodepd
I used port and bind_address as an example which used the params namespace. Should I change them to not use the params namespace?
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
(FM-7399) - Prepare for changelog generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a ssl parameter to the mysql::config class.
Setting ssl to true adds the following parameters to the template.
ssl_ca - path to ssl-ca
ssl_cert - path to ssl-cert
ssl_key - path to ssl-key