Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the deprecated code. #553

Merged
merged 1 commit into from Aug 8, 2014
Merged

Remove all the deprecated code. #553

merged 1 commit into from Aug 8, 2014

Conversation

apenney
Copy link
Contributor

@apenney apenney commented Aug 8, 2014

No description provided.

apenney pushed a commit that referenced this pull request Aug 8, 2014
Remove all the deprecated code.
@apenney apenney merged commit 314dc1f into puppetlabs:master Aug 8, 2014
@igalic
Copy link
Contributor

igalic commented Aug 8, 2014

👍

@igalic
Copy link
Contributor

igalic commented Aug 8, 2014

actually, +:100:

@apenney
Copy link
Contributor Author

apenney commented Aug 8, 2014

That's the kind of +'ing I like! I'm going to work on unit tests for the rest of the afternoon, then look at dragging in the mariadb stuff. (Or in reverse). Is that ready for am erge?

@igalic
Copy link
Contributor

igalic commented Aug 8, 2014

nope… we still don't know how to test it properly, and puppet-dev@ is ignoring us :(

https://groups.google.com/forum/#!searchin/puppet-dev/stubbing$20our$20toes$20on/puppet-dev/VqdKd5ZF7FI/0soJNsbfMVkJ <<<< This might actually be because I don't know how to use google groups.

@apenney
Copy link
Contributor Author

apenney commented Aug 8, 2014

If you rebase it and shove it back into that PR branch I'll pull it locally and flounder about uselessly to see if I can help

@igalic
Copy link
Contributor

igalic commented Aug 8, 2014

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants